Skip to content

refactor(MdComponents): remove Chakra Box component #14855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 2 commits into from
Feb 10, 2025
Merged

refactor(MdComponents): remove Chakra Box component #14855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f08ea92
refactor(MdComponents): remove Chakra Box component
TylerAPfledderer Feb 10, 2025
134eaae
Merge branch 'dev' into refactor/mdcomponents-remove-box
pettinarip Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/components/MdComponents/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { type HTMLAttributes } from "react"
import { Box, type BoxProps } from "@chakra-ui/react"
import { type ComponentProps, type HTMLAttributes } from "react"

import type { ChildOnlyProp } from "@/lib/types"

Expand Down Expand Up @@ -111,7 +110,6 @@ export const HR = () => (
// All base html element components
export const htmlElements = {
a: TooltipLink,
div: Box,
h1: Heading1,
h2: Heading2,
h3: Heading3,
Expand Down Expand Up @@ -147,7 +145,7 @@ export const Title = (props: ChildOnlyProp) => (
<Heading1 className="mt-4" {...props} />
)

export const ContentContainer = (props: Pick<BoxProps, "id" | "children">) => {
export const ContentContainer = (props: ComponentProps<"article">) => {
return (
<MainArticle className="relative flex-[1_1_992px] px-8 pb-8" {...props} />
)
Expand Down