Listen to feature#14820
Merged
Merged
Conversation
corwintines
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Afeter8
approved these changes
Feb 4, 2025
Afeter8
approved these changes
Feb 4, 2025
github-actions
Bot
added
the
dependencies 📦
corwintines
requested review from
asanso,
djrtwo and
fredrik0x
as code owners
corwintines
force-pushed
the
listen-to-feature
branch
from
bc22bb8 to
8d21119
Compare
Contributor
here the audio goes the full width which it shouldnt |
Contributor
this still needs to be added i think cc @corwintines |
Contributor
this might be too short, could we keep the original width for the background @corwintines ? |
Contributor
|
align to centre the component |
pettinarip
approved these changes
Mar 12, 2025
Member
There was a problem hiding this comment.
Noting that we don't have the "You are listening to ..." intro text in this case.
| side="top" | ||
| sideOffset={2} | ||
| className="max-w-80 px-5 text-sm" | ||
| className="z-[10000] max-w-80 px-5 text-sm" |
Member
There was a problem hiding this comment.
Could we use one of the tokens?, in this case z-popover. Mainly to avoid z index conflicts with other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-14820--ethereumorg.netlify.app/what-is-ethereum
https://deploy-preview-14820--ethereumorg.netlify.app/eth
https://deploy-preview-14820--ethereumorg.netlify.app/wallets
https://deploy-preview-14820--ethereumorg.netlify.app/web3
https://deploy-preview-14820--ethereumorg.netlify.app/smart-contracts