Skip to content

feat: migrate staking hierarchy to shadcn/tailwind#14755

Merged
pettinarip merged 10 commits into
ethereum:devfrom
ashiskumar-1999:Migrate-StakingHierarchy-to-Shadcn/Tailwind
Feb 7, 2025
Merged

feat: migrate staking hierarchy to shadcn/tailwind#14755
pettinarip merged 10 commits into
ethereum:devfrom
ashiskumar-1999:Migrate-StakingHierarchy-to-Shadcn/Tailwind

Conversation

@ashiskumar-1999
Copy link
Copy Markdown
Contributor

@ashiskumar-1999 ashiskumar-1999 commented Jan 28, 2025

Description

Migrated all the Chakra imports in Staking Hierarchy to Shadcn/Tailwind.
#13946

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 28, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 77bc305
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67a4b7a72b621600081bc866
😎 Deploy Preview https://deploy-preview-14755--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 1 from production)
Accessibility: 95 (🟢 up 3 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashiskumar-1999 ashiskumar-1999 changed the title refactor: Migrate staking hierarchy to shadcn/tailwind feat: migrate staking hierarchy to shadcn/tailwind Jan 28, 2025
Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiskumar-1999 are you still working on this? do you need help?

@ashiskumar-1999
Copy link
Copy Markdown
Contributor Author

Hey @pettinarip ,
I'm working on this file. I might need some help regarding the color variable implementation in the Tailwind.
Should we add colors directly within className like instead of using the $colorVar.reference?

Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiskumar-1999 went ahead as chatted in discord and did the rest of the work. Was not an easy component to migrate in terms of styles, nor easy to explain in words how to do it without actually doing it xD

Thanks for the help!

@pettinarip pettinarip marked this pull request as ready for review February 6, 2025 13:25
@ashiskumar-1999
Copy link
Copy Markdown
Contributor Author

Thanks @pettinarip, for the help. Yes, It was a bit tricky to migrate this component in terms of styles.

@pettinarip pettinarip merged commit 80efe5c into ethereum:dev Feb 7, 2025
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants