[ShadCN]: Migrate Avatar to ShadCN #14749
Open
+276
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
TylerAPfledderer
changed the title
pettinarip
reviewed
Jan 29, 2025
| ref={ref} | ||
| style={ | ||
| { | ||
| "--avatar-base-shadow-color": "hsl(var(--primary-low-contrast))", |
There was a problem hiding this comment.
Can't we just use shadow-primary-low-contrast? or define it in the theme shadow-avatar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
Avatarto ShadCN in the design system.Important:
IssuesList,FileContributors, andLeaderboardcomponents all useAvatardirectly from Chakra, not from the custom component. This usage is missing the use of the avatar as a link (nohrefprop used).In addition, the general usage of the avatar in prod does not match intent from the design system.
IssuesList, the avatar is accompanied by static text of the contributor's name, and not served as a link to the contributor's profileLeaderboard, the design of the list item is too complex to be able to use the avatar from the design system.FileContributorsit is also a little too complex for the avatar from the design system, as it adds static text around the contributor linkWould need some direction on how to further proceed with this PR to address the above use cases, or resolve them in a separate PR.
Related Issue
#13946