Shadcn Migrate: developers/tutorials.tsx #14710
Conversation
JoeChenJ
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@JoeChenJ left a comment about the Tag and Badge migrations going on in a different PR. The rest looks fine.
| @@ -43,43 +39,50 @@ import { | |||
| import externalTutorials from "@/data/externalTutorials.json" | |||
|
|
|||
| import { useBreakpointValue } from "@/hooks/useBreakpointValue" | |||
| import { useRtlFlip } from "@/hooks/useRtlFlip" | |||
|
|
|||
| const FilterTag = forwardRef<{ isActive: boolean; name: string }, "button">( | |||
There was a problem hiding this comment.
Hey sorry for not noticing this before, but we are doing the tag migration in a different PR #13976 and since the visual results in this PR for it are not perfect, I think it will be just easier to revert this change.
vs prod
src/pages/developers/tutorials.tsx
Outdated
| </Text> | ||
| <Badge variant="secondary"> | ||
| </h4> | ||
| <Badge |
There was a problem hiding this comment.
Similar as the previous comment. We are replacing the Badge with the ui/Tag. Im adding a note about this in the GH guidance.
Since this work is done in #13976 we could:
- revert this part
- or use the
ui/Tagcomponent with<Tag variant="outline">
src/pages/developers/tutorials.tsx
Outdated
| }} | ||
| <Flex className="mb-8 flex-col items-start justify-between gap-y-4 md:-mb-4 md:flex-row"> | ||
| <h4 | ||
| className={`relative me-0 text-body after:ml-2 after:inline-block after:italic after:transition-all after:duration-100 after:ease-in-out after:content-['↗'] md:me-24 ${tutorial.isExternal ? "after:inline-block" : "after:hidden"}`} |
There was a problem hiding this comment.
We could use cn() for these conditionals
Description
Migrate developers/tutorials.tsx to Shadcn
Related Issue
#13946