Skip to content

Fix broken SVG assets icons path by using absolute URL from origin#14614

Merged
corwintines merged 2 commits into
ethereum:devfrom
paschaldev:dev
Feb 12, 2025
Merged

Fix broken SVG assets icons path by using absolute URL from origin#14614
corwintines merged 2 commits into
ethereum:devfrom
paschaldev:dev

Conversation

@paschaldev
Copy link
Copy Markdown
Contributor

Description

SVG Download links are broken on this page: https://ethereum.org/en/assets/

This is caused by internalization prepending the locale in the URL

Related Issue

#14600

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 7, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2058b25
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/677e2e9cfd190600086d1e37
😎 Deploy Preview https://deploy-preview-14614--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@paschaldev paschaldev changed the title Fix broken SVG assets icons path Fix broken SVG assets icons path by using absolute URL from origin Jan 7, 2025
@corwintines corwintines merged commit fe11d72 into ethereum:dev Feb 12, 2025
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Feb 12, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants