Skip to content

Fix grammar and spelling errors in typescript.md and Indonesian translations (index.md)#14395

Merged
wackerow merged 3 commits into
ethereum:devfrom
futreall:dev
Jul 18, 2025
Merged

Fix grammar and spelling errors in typescript.md and Indonesian translations (index.md)#14395
wackerow merged 3 commits into
ethereum:devfrom
futreall:dev

Conversation

@futreall
Copy link
Copy Markdown
Contributor

PR Description

This pull request includes the following changes:

  1. typescript.md:

    • Corrected grammar in a comment:
      • Changed: type can not
      • To: type cannot
  2. **index.md **:

    • Fixed a spelling issue:
      • Changed: manjadikan
      • To: menjadikan
    • Adjusted wording for clarity:
      • Changed: cermerlang
      • To: cemerlang
  3. **index.md **:

    • Corrected duplication:
      • Changed: iadalah
      • To: adalah

These edits aim to improve accuracy and consistency in both English and Indonesian documentation.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits documentation 📖 Change or add documentation translation 🌍 This is related to our Translation Program labels Nov 24, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 24, 2024

Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 30c0338
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67431bad5dc33d000838dbef

@futreall
Copy link
Copy Markdown
Contributor Author

futreall commented Dec 4, 2024

@Magkoooh Hey! Could you please run the migration to apply the changes? I’d really appreciate it!

@futreall
Copy link
Copy Markdown
Contributor Author

@corwintines ?

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Dec 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 602d37b src/data/community-events.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2025

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Feb 9, 2025
@futreall
Copy link
Copy Markdown
Contributor Author

@Magkoooh merge?

@github-actions github-actions Bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Feb 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Apr 13, 2025
@wackerow
Copy link
Copy Markdown
Member

@claude please review Malay translation updates in this PR

@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 18, 2025
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jul 18, 2025

Claude finished @wackerow's task —— View job


Reviewing Malay Translation Updates

Todo List:

  • Read the changed files to understand the specific translation updates
  • Analyze the Malay language corrections for linguistic accuracy
  • Review the changes against Malay translation standards
  • Provide comprehensive review feedback

Review Summary

I've thoroughly reviewed the Malay translation updates in this PR. All changes are linguistically accurate and improve the overall quality of the translations.

Approved Changes:

1. docs/typescript.md (Line 17):

  • "type can not""type cannot"
  • Assessment: Valid grammar improvement. "Cannot" is preferred in formal documentation.

2. public/content/translations/ms/dao/index.md (Line 37):

  • "iadalah""adalah"
  • Assessment: Correct fix for concatenation error. The sentence reads properly with just "adalah" (is).

3. public/content/translations/ms/defi/index.md:

  • Line 142: "manjadikan""menjadikan"
    • Assessment: Essential correction. "Menjadikan" is the standard Malay verb meaning "to make/cause to become."
  • Line 248: "cermerlang""cemerlang"
    • Assessment: Proper spelling correction. "Cemerlang" (excellent/brilliant) is the correct form.

Translation Quality Assessment

These corrections demonstrate good attention to detail and proper understanding of Malay language conventions:

  • ✅ Spelling errors corrected
  • ✅ Proper word formation maintained
  • ✅ Consistent with Malaysian/Malay language standards
  • ✅ No impact on meaning or context

Recommendation

APPROVE - All changes enhance the quality and accuracy of the Malay translations without affecting the content meaning. The corrections address legitimate language issues and follow proper Malay spelling conventions.

Note: The PR title incorrectly refers to "Indonesian translations" but these are Malay translations (language code "ms").


Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @futreall! Thanks for the help here, sorry for delays. Using the claude review to help review the Malay updates since they're small. Looks good! Pulling in

(Crowdin has been updated)

@wackerow wackerow merged commit be7fa5b into ethereum:dev Jul 18, 2025
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Jul 18, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @futreall for translations and bug fix

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @futreall! 🎉

This was referenced Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits documentation 📖 Change or add documentation translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants