Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dir-responsive margin #14184

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: dir-responsive margin #14184

merged 1 commit into from
Oct 18, 2024

Conversation

wackerow
Copy link
Member

Description

  • Update mr (margin-right) to me (margin-inline-end) to fix dir-responsive margin on calendar icon for EventCard

Related Issue

image

@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 83a3d58
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6711628098c78a0008d442d8
😎 Deploy Preview https://deploy-preview-14184--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 51 (🔴 down 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pettinarip
pettinarip approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit 8ff23ae into dev Oct 18, 2024
9 of 10 checks passed
@pettinarip pettinarip deleted the rtl-patch branch October 18, 2024 07:48
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @pettinarip