Skip to content

feat: fetch next year events #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: fetch next year events #14182

merged 2 commits into from
Nov 28, 2024

Conversation

wackerow
Copy link
Member

Description

  • Adds an attempt to fetch from the same Google Sheet for next years events
  • Google Sheet has different pages for each year, matchable by passing the year number
  • If results found, adds to ethereumEvents array

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f24ec0b
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67489dc5051b7e000806a9a0
😎 Deploy Preview https://deploy-preview-14182--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 51 (🔴 down 3 from production)
Accessibility: 93 (🟢 up 1 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow
Copy link
Member Author

@corwintines We'll need a valid GOOGLE_API_KEY added to our GH secrets before this one will work... not sure what happened to the existing one, but did you handle this before?

Then we can run the workflow directly from this branch to confirm it works before we merge this.

@wackerow
Copy link
Member Author

Bump cc: @corwintines @pettinarip

@corwintines corwintines self-assigned this Nov 18, 2024
@corwintines corwintines merged commit d240e31 into dev Nov 28, 2024
5 of 6 checks passed
@corwintines corwintines deleted the events-fetching branch November 28, 2024 16:48
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants