Data loader #14179
Merged
Data loader #14179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
github-actions
bot
added
config ⚙️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
pettinarip
commented
Oct 17, 2024
src/components/BigNumber/index.tsx
Outdated
There was a problem hiding this comment.
Changes for testing purposes. This will show the full date and time and will help us to check that the data has been updated.
pettinarip
commented
Oct 17, 2024
src/pages/index.tsx
Outdated
|
|
||
| type Props = BasePageProps & { | ||
| metricResults: AllMetricData | ||
| rssData: { rssItems: RSSItem[]; blogLinks: CommunityBlog[] } | ||
| } | ||
|
|
||
| // In seconds | ||
| const REVALIDATE_TIME = 60 |
There was a problem hiding this comment.
Revert once we finish testing.
wackerow
reviewed
Oct 17, 2024
Co-authored-by: Paul Wackerow <[email protected]>
|
Marked as "Blocked" until reviewed, approved, and test commits reverted. |
corwintines
approved these changes
Oct 20, 2024
wackerow
approved these changes
Oct 20, 2024
This was referenced Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a data loader function to handle data caching, error handling and mock data.
Important: the last two commits are for testing purposes. They need to be removed once we get an approval.
Testing params: current build is only building
enand the home page has a revalidate time of 60 seconds.TODO