-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SocialListItem.tsx to tailwind #14167
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @yun-chiao! waiting for the build to finish but looks good 💪🏼
Hi @pettinarip , I've noticed that the Netlify deploy preview for my PR is failing. I'm wondering if this issue is something I should be responsible for fixing, or if it's related to a broader issue that will be resolved elsewhere before merging this PR? Please let me know how I should proceed. Thanks! |
Hey, no, its not related to your PR. Sorry about that. We are currently fixing the issue. As soon as it's fixed, I'll trigger this PR again to get a proper build. |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
This PR updates the SocialListItem.
@chakra-ui/react
.Note
Tailwind cannot dynamically handle
text-[${socialColors[socialIcon]}]
, so I used inlinestyle={{ color: socialColors[socialIcon] }}
as an alternative.For more details on this issue, you can refer to the discussion here: JIT TailwindCSS: Using Variable in bg-* Not Rendering Color.
Related Issue
#13946
Screenshot
localhost
ethereum.org