Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SocialListItem.tsx to tailwind #14167

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

yun-chiao
Copy link
Contributor

Description

This PR updates the SocialListItem.

  • Replace components of @chakra-ui/react.
  • Migrate css to tailwind.

Note

Tailwind cannot dynamically handle text-[${socialColors[socialIcon]}], so I used inline style={{ color: socialColors[socialIcon] }} as an alternative.

For more details on this issue, you can refer to the discussion here: JIT TailwindCSS: Using Variable in bg-* Not Rendering Color.

Related Issue

#13946

Screenshot

localhost

截圖 2024-10-15 下午9 32 15

ethereum.org

截圖 2024-10-15 下午9 32 23

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5e4dbcd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670fa16e8ec0f3000848dd93
😎 Deploy Preview https://deploy-preview-14167--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 51 (🔴 down 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Oct 15, 2024
41 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @yun-chiao! waiting for the build to finish but looks good 💪🏼

@yun-chiao
Copy link
Contributor Author

Hi @pettinarip ,

I've noticed that the Netlify deploy preview for my PR is failing. I'm wondering if this issue is something I should be responsible for fixing, or if it's related to a broader issue that will be resolved elsewhere before merging this PR?

Please let me know how I should proceed. Thanks!

@pettinarip
Copy link
Member

Hi @pettinarip ,

I've noticed that the Netlify deploy preview for my PR is failing. I'm wondering if this issue is something I should be responsible for fixing, or if it's related to a broader issue that will be resolved elsewhere before merging this PR?

Please let me know how I should proceed. Thanks!

Hey, no, its not related to your PR. Sorry about that.

We are currently fixing the issue. As soon as it's fixed, I'll trigger this PR again to get a proper build.

@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
@wackerow wackerow merged commit b10fbb2 into ethereum:dev Oct 22, 2024
9 of 10 checks passed
Copy link

gitpoap-bot bot commented Oct 22, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants