Skip to content

Add smart contract quiz fixes #13776#14162

Merged
wackerow merged 14 commits into
ethereum:devfrom
CryptoDelirium:dev
Jul 23, 2025
Merged

Add smart contract quiz fixes #13776#14162
wackerow merged 14 commits into
ethereum:devfrom
CryptoDelirium:dev

Conversation

@CryptoDelirium
Copy link
Copy Markdown
Contributor

@CryptoDelirium CryptoDelirium commented Oct 13, 2024

Accidentally closed previous PR #13981. References issue #13776.

Quiz content added. Linked quiz to global counter

In collab with @JanetMo

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Oct 13, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 13, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2a3a3e7
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6881436b432ea80008701c0f
😎 Deploy Preview https://deploy-preview-14162--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 1 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 58 (🔴 down 1 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shiva-Sai-ssb
Copy link
Copy Markdown
Contributor

Hey @TC1211 / @Qwerky7835, the smart contract quiz is working as expected on the quizzes page, but it is not functioning properly on the smart contracts page.

See the screenshot below to see how the quiz appears on the page, or you can view how the quiz appears in the deploy preview link (https://deploy-preview-14162--ethereumorg.netlify.app) provided by the Netlify bot.

smart-contracts

To fix this, refer to the suggestion provided here: #13704 (comment).

Additionally, reference the issue number in the PR description you are referring to.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Oct 19, 2024
@CryptoDelirium
Copy link
Copy Markdown
Contributor Author

Fixed the quiz widget on the smart contract page.

@konopkja konopkja added needs dev approval 🧑‍💻 Approval from a developer is needed before merging needs review 👀 and removed translation 🌍 This is related to our Translation Program tooling 🔧 Changes related to tooling of the project labels Oct 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 28, 2024
@github-actions github-actions Bot added tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Mar 25, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work everyone! Thanks to @Qwerky7835 @CryptoDelirium @Shiva-Sai-ssb @JanetMo for helping with this... Apologies for delays so far.

Left a round of comments which I think will take this over the line. @CryptoDelirium would you be capable/interested in making some updates?

Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
@JanetMo
Copy link
Copy Markdown
Contributor

JanetMo commented Mar 29, 2025

@wackerow Thanks for reviewing. From my side, feel free to implement the suggestions, sounds very good.

@github-actions github-actions Bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 30, 2025
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
CryptoDelirium and others added 5 commits March 31, 2025 12:51
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Apply review changes

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@CryptoDelirium CryptoDelirium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied most of the changes. Some others I left comments and suggestions on.

Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CryptoDelirium! Left another round of comments, lemme know what you think here and we'll try to get it in soon.. thanks!

Comment thread src/intl/en/learn-quizzes.json Outdated
"smart-contracts-1-b-label": "They are linked to an AI system, which allows them to make decisions that trigger blockchain transactions.",
"smart-contracts-1-b-explanation": "Smart contracts can actually execute transactions automatically, but only according to an ‘if this then that’ logic that is prescribed in the code. They do not use AI.",
"smart-contracts-1-c-label": "They are programs stored on the blockchain that follow an 'if this then that' logic, and are guaranteed to execute according to the rules defined by the code.",
"smart-contracts-1-c-explanation": "A smart contract is a piece of code that can be executed automatically according to an 'if this then that' logic.",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure... would err on the side of more concise.. "unchangeable" may be easier to understand than "immutable" though

Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Comment thread src/intl/en/learn-quizzes.json Outdated
Copy link
Copy Markdown
Contributor

@JanetMo JanetMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wackerow, thanks for your comments, we're fine with the suggested changes.

@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 24, 2025
@wackerow wackerow mentioned this pull request Jul 16, 2025
2 tasks
Comment thread src/intl/en/learn-quizzes.json Outdated
"smart-contracts-4-b-explanation": "While protocol changes can sometimes use smart contracts, their creation and definition are proposed through transparent online forums and implemented in client software.",
"smart-contracts-4-c-label": "Non-fungible tokens (NFTs)",
"smart-contracts-4-c-explanation": "Smart contracts are used to define a wide range of NFTs, ranging from digital art to asset ownership certificates.",
"smart-contracts-4-d-label": "Decentralized autonomous organizations (DAOs)",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to patch this as well.. swapping DAO out for "insurance policy" since we don't mention DAOs on the page, but we do mention insurance.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, will use DEX

@wackerow wackerow removed translation 🌍 This is related to our Translation Program tooling 🔧 Changes related to tooling of the project Status: Stale This issue is stale because it has been open 30 days with no activity. needs review 👀 labels Jul 23, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the updates discussed, thanks everyone! Pulling this in

@wackerow wackerow merged commit 21becf4 into ethereum:dev Jul 23, 2025
5 of 6 checks passed
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Jul 23, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @CryptoDelirium for content

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @CryptoDelirium! 🎉

@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @JanetMo for content

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

@JanetMo already contributed before to content

This was referenced Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits needs dev approval 🧑‍💻 Approval from a developer is needed before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants