migrated trilemma modal to shadcn ui sheet component #14102
+29,625
−3,876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharv-av
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
the
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks @atharv-av.
There are a few files that shouldn't be modified. LMK if you need help.
.env.example
Outdated
There was a problem hiding this comment.
This file should not be modified. Lets revert it.
package-lock.json
Outdated
There was a problem hiding this comment.
Same, revert this file. We shouldn't have any changes in this file
yarn.lock
Outdated
| </DrawerContent> | ||
| </Drawer> | ||
| </Hide> | ||
| <Sheet open={mobileModalOpen} onOpenChange={handleModalClose}> |
There was a problem hiding this comment.
We need to add a condition to only display/use the Sheet in mobile devices. Currently I can see it on desktop https://deploy-preview-14102--ethereumorg.netlify.app/en/roadmap/vision/
|
Hey @atharv-av wanted to know if you are blocked on this PR or need help. LMK thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trilemma modal previously used chakra imports. I replaced them with shadcn ui and tailwind css. Also, I used components from
@/components/ui/flex