Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update shapeshift logo #14085

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

firebomb1
Copy link
Contributor

@firebomb1 firebomb1 commented Oct 7, 2024

Description

  • Updates the ShapeShift Mobile wallet logo following the recent brand asset update.
  • Switching to SVG format.
  • Update the wallet last_updated field.

Preview link

https://deploy-preview-14085--ethereumorg.netlify.app/en/wallets/find-wallet

Related Issue

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a73ed63
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67040da96e9d7800086f4d98
😎 Deploy Preview https://deploy-preview-14085--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@firebomb1
Copy link
Contributor Author

firebomb1 commented Oct 7, 2024

Looks like SVG files aren't supported through that config file yet, switching back to a 200x200 transparent PNG.

@wackerow
Copy link
Member

wackerow commented Oct 9, 2024

Hey @firebomb1, thanks for the help here. Curious, you pointed to the ShapeShift assets page where I see this icon, but I also see an icon for light mode (black on white), and at the bottom I still see the blue icon that is being replaced in this PR.

Can you help clarify the changes here? Curious if you're affiliated with the ShapeShift team, or if you happened to come across this? Just trying to confirm that we actually want to switch this over, since the black background is a box in light mode and the blue circle handles that.

If we do want to switch, we should probably also adjust the "brand color" to black so the decorative fade line updates as well:

image

@wackerow wackerow added question ❓ Further information is requested Status: Blocked 🛑 This is blocked labels Oct 9, 2024
@corwintines
Copy link
Member

+1, would like a bit of clarity around the brand assets here given what is currently being used exists on the assets page

@firebomb1
Copy link
Contributor Author

Hey @wackerow and @corwintines, thanks for your quick responses. I'm part of the ShapeShift DAO as a contributor to the Marketing and Business Development Workstream. I've updated our listing on ethereum.org a couple times already. We're now trying to set a more coherent use of the logos and would like this reflected everywhere our app/brand is mentioned.

The logo version with the blue circular background is intended for the FOX token only (our DAO's governance token). The current logo on ethereum.org uses a gradient background based on that color, and a border was added, which does not align with our brand guidelines. This usage was not very appropriate even before the recent update to our brand assets 😅

The current brand_color would remain on-brand as it's part of the color scheme of our brand (it's used for UI buttons and other elements, not just the token logo).

image

But if we have to change it for something darker to better match the black background of the new logo in this listing I think it should be the Midnight color (#0D182D). If you find that better for ethereum.org, tell me and I will update the PR.

@wackerow wackerow removed question ❓ Further information is requested Status: Blocked 🛑 This is blocked labels Oct 9, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the explanation @firebomb1
LGTM! Pulling in

@wackerow wackerow merged commit 2eda7ef into ethereum:dev Oct 9, 2024
6 of 7 checks passed
@firebomb1
Copy link
Contributor Author

No problem @wackerow, thanks for your care and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ShapeShift Mobile logo
3 participants