-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update shapeshift logo #14085
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks like SVG files aren't supported through that config file yet, switching back to a 200x200 transparent PNG. |
Hey @firebomb1, thanks for the help here. Curious, you pointed to the ShapeShift assets page where I see this icon, but I also see an icon for light mode (black on white), and at the bottom I still see the blue icon that is being replaced in this PR. Can you help clarify the changes here? Curious if you're affiliated with the ShapeShift team, or if you happened to come across this? Just trying to confirm that we actually want to switch this over, since the black background is a box in light mode and the blue circle handles that. If we do want to switch, we should probably also adjust the "brand color" to black so the decorative fade line updates as well: |
+1, would like a bit of clarity around the brand assets here given what is currently being used exists on the assets page |
Hey @wackerow and @corwintines, thanks for your quick responses. I'm part of the ShapeShift DAO as a contributor to the Marketing and Business Development Workstream. I've updated our listing on ethereum.org a couple times already. We're now trying to set a more coherent use of the logos and would like this reflected everywhere our app/brand is mentioned. The logo version with the blue circular background is intended for the FOX token only (our DAO's governance token). The current logo on ethereum.org uses a gradient background based on that color, and a border was added, which does not align with our brand guidelines. This usage was not very appropriate even before the recent update to our brand assets 😅 The current But if we have to change it for something darker to better match the black background of the new logo in this listing I think it should be the Midnight color ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the explanation @firebomb1
LGTM! Pulling in
No problem @wackerow, thanks for your care and the merge! |
Description
Switching to SVG format.last_updated
field.Preview link
https://deploy-preview-14085--ethereumorg.netlify.app/en/wallets/find-wallet
Related Issue