Deprecate _buildspace #14075
Merged
Deprecate _buildspace #14075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piyush-Tilokani
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content 🖋️
|
@all-contributors can you add @Piyush-Tilokani for content |
|
I've put up a pull request to add @Piyush-Tilokani! 🎉 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This was referenced Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
src/pages/developers/learning-tools.tsxto de-list_buildspacefrom the learning toolsDescription
As stated in #14064
_buildspacehas been deprecated and hence needed to be removed from learning tools.Therefore, I modified the
src/pages/developers/learning-tools.tsxfile accordingly to remove it from learning tools.Related Issue
Closes #14064
Screenshots
This how the page currently looks like
This is how it looks like after my changes
I hope this is good enough and helps.
Do let me know if any changes are needed.
Please review and merge