Shadcn migration - DocLink #14036
Merged
Shadcn migration - DocLink #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
saurabhburade
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
reviewed
Oct 8, 2024
src/components/DocLink.tsx
Outdated
| transform={flipForRtl} | ||
| </Center> | ||
| <Stack className="flex-1"> | ||
| <p className="font-semibold text-[#4c4c4c] dark:text-[#cccccc]"> |
There was a problem hiding this comment.
@nloureiro what do you think about using text-body in this case?
There was a problem hiding this comment.
pettinarip
added
needs design approval 🧑🎨
wackerow
requested changes
Oct 22, 2024
|
Thanks for this @saurabhburade! Just a tiny request to avoid using one-off colors, otherwise this looks great! |
pettinarip
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
DocLinkto tailwindRelated Issue
#13946