Skip to content

fix: dropdown intl bugs #14022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: dropdown intl bugs #14022

merged 2 commits into from
Oct 2, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 2, 2024 •
edited
Loading

Target: staging

Description

  • Fixes dropdown strings for Roadmap layout, passing key through t() first
  • Fixes dropdown menu title/aria-label for mobile StakingConsiderations menu

Preview link

https://deploy-preview-14022--ethereumorg.netlify.app/en/roadmap/

Related Issue

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 395d032
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66fd241cfc3c1c0008c7a08f
😎 Deploy Preview https://deploy-preview-14022--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 47 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Oct 2, 2024
@wackerow wackerow changed the base branch from dev to staging October 2, 2024 15:53
@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Oct 2, 2024
@corwintines corwintines merged commit 9417a84 into staging Oct 2, 2024
8 of 10 checks passed
@corwintines corwintines deleted the fix-dropdown-intl branch October 2, 2024 15:55
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Oct 21, 2024
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@lukassim lukassim

Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackerow @corwintines @lukassim