Skip to content

Shadcn migration - toc#14021

Merged
wackerow merged 8 commits into
devfrom
shadcn-toc
Jan 31, 2025
Merged

Shadcn migration - toc#14021
wackerow merged 8 commits into
devfrom
shadcn-toc

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented Oct 2, 2024

Description

Migrates the ToC component using shadcn dropdown-menu.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Oct 2, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c8e0df0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6786865dbf6d7000082d1ca5
😎 Deploy Preview https://deploy-preview-14021--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 50 (🟢 up 2 from production)
Accessibility: 95 (🟢 up 3 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

wackerow
wackerow reviewed Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-10-03.at.16.57.36.mov

Looking good overall! Noticing we lost the scroll-tracking though. Were we looking to include that here?

wackerow
wackerow reviewed Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pettinarip Left a comment about aligning the width with the DS... Not intending to scope creep though, so if you'd prefer we can just adjust this separately, will leave it up to you.

Comment thread src/components/TableOfContents/index.tsx
wackerow
wackerow requested changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-10-03.at.16.57.36.mov

Regression to the scroll-tracking

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 23, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
@TylerAPfledderer
Copy link
Copy Markdown
Contributor

TylerAPfledderer commented Dec 2, 2024

@pettinarip FYI I tagged this PR in the Notion page 👍🏼

@github-actions github-actions Bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2025

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 2, 2025
@pettinarip
Copy link
Copy Markdown
Member Author

pettinarip commented Jan 14, 2025

Screen.Recording.2024-10-03.at.16.57.36.mov
Regression to the scroll-tracking

Good catch! I've fixed this.

@pettinarip pettinarip requested a review from wackerow January 14, 2025 15:57
@pettinarip pettinarip removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 14, 2025
@pettinarip
Copy link
Copy Markdown
Member Author

pettinarip commented Jan 16, 2025

@wackerow this is ready to be reviewed again

wackerow
wackerow approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@wackerow wackerow merged commit 7217b9c into dev Jan 31, 2025
@wackerow wackerow deleted the shadcn-toc branch January 31, 2025 15:27
This was referenced Feb 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines

@minimalsm minimalsm Awaiting requested review from minimalsm

+1 more reviewer

@Afeter8 Afeter8 Afeter8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pettinarip @TylerAPfledderer @wackerow @minimalsm @Afeter8