Skip to content

Shadcn migration - tag button#13999

Merged
wackerow merged 3 commits into
devfrom
shadcn-tag-button
Jan 31, 2025
Merged

Shadcn migration - tag button#13999
wackerow merged 3 commits into
devfrom
shadcn-tag-button

Conversation

@pettinarip
Copy link
Copy Markdown
Member

Description

Implementation of TagButton to cover hover, focus, active states.

Related Issue

#13972

Base automatically changed from shadcn-tag to dev October 1, 2024 17:19
@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 14, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cf0d3a8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6788d6bdac39ef00088aa452
😎 Deploy Preview https://deploy-preview-13999--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 14, 2025
@pettinarip pettinarip marked this pull request as ready for review January 16, 2025 12:38
@nloureiro
Copy link
Copy Markdown
Contributor

@pettinarip, how can I see this on the browser?

@pettinarip
Copy link
Copy Markdown
Member Author

@pettinarip, how can I see this on the browser?

Ah sorry. You can see this in the generated storybook under molecules/display-content/new-tags/style-variants-button. Here

@nloureiro
Copy link
Copy Markdown
Contributor

@pettinarip, how can I see this on the browser?

Ah sorry. You can see this in the generated storybook under molecules/display-content/new-tags/style-variants-button. Here

they look great! let's go!!!

@wackerow wackerow merged commit 0cccfda into dev Jan 31, 2025
@wackerow wackerow deleted the shadcn-tag-button branch January 31, 2025 15:25
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants