Removed deprecated eth_coinbase from json-rpc docs[#13996] #13997
Conversation
MaryNfs
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks @MaryNfs! Agree with the issue you posted, but am hesitant to remove this entirely for archival/historical purposes.
I might suggest something similar to what the playground we link out to does:
https://ethereum-json-rpc.com/?method=eth_coinbase
If you go here you'll see that the eth_coinbase method is still available, but executing shows "details": "Method not supported".
I'd suggest we keep the h3 section and initial comment, and add a note that this method has been deprecated, and note as of when this occured. Something like this:
### eth_coinbase {#eth_coinbase}
Returns the client coinbase address.
**No longer supported (deprecated as of _____)**
Hi @wackerow |
| @@ -387,6 +387,8 @@ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":1} | |||
|
|
|||
| Returns the client coinbase address. | |||
|
|
|||
| > **Note:** This method has been deprecated as of **v1.14.0** and is no longer supported. Attempting to use this method will result in a "Method not supported" error. | |||
There was a problem hiding this comment.
Attempting to use this method will result in a "Method not supported" error.
Should we consider replacing this sentence with a comment similar to below about using eth_accounts instead? Don't think it needs to block here, but curious thoughts for further iteration.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @MaryNfs for content bug patch |
|
I've put up a pull request to add @MaryNfs! 🎉 |
Description
As discussed in ethereum/go-ethereum#29747, eth_coinbase no longer returns an address in v1.14.0+ and has been deprecated.
This PR removes the deprecated eth_coinbase RPC method from the JSON-RPC API list.
Related Issue