Skip to content

Create Story for Contributors Component#13978

Merged
wackerow merged 6 commits into
ethereum:devfrom
Baystef:feat/contributorscomponent-story
Jul 22, 2025
Merged

Create Story for Contributors Component#13978
wackerow merged 6 commits into
ethereum:devfrom
Baystef:feat/contributorscomponent-story

Conversation

@Baystef
Copy link
Copy Markdown
Contributor

@Baystef Baystef commented Sep 26, 2024

Description

  • Move /src/components/Contributors.tsx to /src/components/Contributors/index.tsx
  • Fix any filepath changes to imports for the Contributors component
  • Create story file /src/components/Contributors/Contributors.stories.tsx
  • Writes story testing render of Contributors component in context of use

Related Issue

Closes #13878

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 26, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1054562
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/687ef871ad3d0100083460e7
😎 Deploy Preview https://deploy-preview-13978--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 51 (🟢 up 2 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 22, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @Baystef, sorry for delays here... just patch a couple things here to pass in a static list of contributors so as that list changes the component doesn't keep getting flagged.

Aside, the story wasn't working because of a syntax error with the Contributors component which I patched (needed height/width)... pulling in!

@wackerow wackerow merged commit eff0dd2 into ethereum:dev Jul 22, 2025
6 of 7 checks passed
This was referenced Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create story for Contributors component

2 participants