Skip to content

Migrate UpgradeTableOfContents to Shadcn #13974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

minimalsm
Copy link
Contributor

Description

  • Updates UpgradeTableOfContents to Shadcn

Related Issue

#13946

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3232008
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f547c53827970008aa2816
😎 Deploy Preview https://deploy-preview-13974--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

import type { ToCItem } from "@/lib/types"

import { BaseLink } from "@/components/Link"
import { ItemsListProps } from "@/components/TableOfContents/ItemsList"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this will be done as part of ToC update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

@minimalsm minimalsm changed the title Update UpgradeTableOfContents to Shadcn Migrate UpgradeTableOfContents to Shadcn Sep 26, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit 6cc66a7 into dev Sep 27, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the updateTableOfContents branch September 27, 2024 06:46
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants