Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migration - ContributorsQuizBanner #13957

Merged

Conversation

saurabhburade
Copy link
Contributor

Description

Migrate ContributorsQuizBanner to tailwind

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 84e36e0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f3f23960bbd20008837e1d
😎 Deploy Preview https://deploy-preview-13957--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhburade
Copy link
Contributor Author

Hi @pettinarip, I need a suggestion about the PeopleLearning image. It's visually unused and if we use it where & how to place it.
For reference

Without image ==> Already in prod
Screenshot 2024-09-25 at 12 26 46 PM

With Image
Screenshot 2024-09-25 at 12 27 13 PM

@pettinarip
Copy link
Member

Hi @pettinarip, I need a suggestion about the PeopleLearning image. It's visually unused and if we use it where & how to place it. For reference

You caught a bug!

Looking at this, the problem is that the className is being overridden. We need to destructure it from the props and pass it to the cn function to make it work properly.

function ContributorsQuizBanner({
  className,
  ...props
}: React.HTMLAttributes<HTMLDivElement>) {
  return (
    <aside
      className={cn(
        "flex flex-col rounded md:flex-row",
        "bg-gradient-to-r from-accent-a/10 to-accent-c/10 dark:from-accent-a/20 dark:to-accent-c-hover/20",
        className
      )}
      {...props}

With that you should see the image and continue with the migration (and fix a bug xD).

@pettinarip pettinarip mentioned this pull request Sep 27, 2024
65 tasks
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! @saurabhburade lgtm

@pettinarip pettinarip merged commit ccec23f into ethereum:dev Sep 27, 2024
8 of 9 checks passed
This was referenced Oct 2, 2024
@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants