-
Notifications
You must be signed in to change notification settings - Fork 5.1k
theme: use 16px font for alert descriptions #13953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but this needs Design approval as well.
Here is the Storybook where you can see the new Alerts with the font size change
https://63b7ea99632763723c7f4d6b-aaqognawns.chromatic.com/?path=/story/molecules-action-feedback-alerts--variants
Now both, the Title and Description, have 16px. I think I would prefer to keep the Title a bit bigger in size, maybe 18px?
This is what I have on the DS > The only difference is that the yellow one uses the default (body) text color on all the text. For contrast purposes. |
@wackerow one more thing based on your feedback on figma > bump the text to 16px |
Okay. That is the only change in this PR (16px font); was not meant to address anything color related. If that looks good to you @nloureiro do me a favor and slap an approval on here 😄 |
(For the content of our |
Description
Proposal: Use 16px font size as default for
ui/alert
componentExample screenshot
Preview link
https://deploy-preview-13953--ethereumorg.netlify.app/en/get-eth
https://ethereum.org/en/get-eth