Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop and mobile 16 px font #13933

Merged
merged 3 commits into from
Sep 24, 2024
Merged

desktop and mobile 16 px font #13933

merged 3 commits into from
Sep 24, 2024

Conversation

nloureiro
Copy link
Contributor

Testing the font size more prominent on mobile for accessibility

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8e9398c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f3168dcc9be30008e15f54
😎 Deploy Preview https://deploy-preview-13933--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🟢 up 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why would we suddenly make the mobile text larger than desktop?

@wackerow
Copy link
Member

(And just flipping to draft while "WIP"; flip back when ready)

@wackerow wackerow marked this pull request as draft September 23, 2024 18:44
@nloureiro
Copy link
Contributor Author

Just curious, why would we suddenly make the mobile text larger than desktop?

The idea was to flip back to 16 on both screen sizes, but then @konopkja "pushed" me to test with 18

What do you think? Could you test it on your phone and tell us how it feels? Is it better to read on the phone?

@nloureiro nloureiro changed the title [DESING WIP]Test 16 desktop and mobile 18 px font desktop and mobile 16 px font Sep 24, 2024
@nloureiro nloureiro added a11y ♿️ This issue relates to accessibility design All the issues related to design should use this tag labels Sep 24, 2024
@nloureiro nloureiro marked this pull request as ready for review September 24, 2024 13:37
@nloureiro
Copy link
Contributor Author

@wackerow, let's push this on the next deployment with a 16px on all screens and discuss the 18px later... so, ready for review :)

@konopkja
Copy link
Contributor

@wackerow, let's push this on the next deployment with a 16px on all screens and discuss the 18px later... so, ready for review :)

actually thats next thursday no? id say thats a bit long waiting time

`text-md` = 16px = default font size
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling this into dev. Can hot fix separately if we feel it's warranted.

@wackerow wackerow merged commit e4d547f into dev Sep 24, 2024
7 of 10 checks passed
@wackerow wackerow deleted the bigger-font branch September 24, 2024 19:54
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y ♿️ This issue relates to accessibility design All the issues related to design should use this tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants