-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop and mobile 16 px font #13933
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why would we suddenly make the mobile text larger than desktop?
(And just flipping to draft while "WIP"; flip back when ready) |
The idea was to flip back to 16 on both screen sizes, but then @konopkja "pushed" me to test with 18 What do you think? Could you test it on your phone and tell us how it feels? Is it better to read on the phone? |
@wackerow, let's push this on the next deployment with a 16px on all screens and discuss the 18px later... so, ready for review :) |
actually thats next thursday no? id say thats a bit long waiting time |
`text-md` = 16px = default font size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling this into dev
. Can hot fix separately if we feel it's warranted.
Testing the font size more prominent on mobile for accessibility