truncate long event description #13919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitvekariya
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Hey @sumitvekariya! Thanks for the PR... Apologies if the issue may have been misleading, but I think we can get away with simply restricting the line count here (instead of word count), which we can use a simply TailwindCSS class for this: line-clamp-x... by default this has up to line-clamp-6, so I would suggest this )(just chatted with @konopkja as well who is in agreement)
Left a suggestion for how we can simplify to use this approach
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
corwintines
changed the title
This was referenced Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The event description had no text limitation and could have been too long. So now event description is limited to 230 characters, if longer than that it is truncated to 230 characters followed by
...Related Issue
#13914