Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small css touch on the errors on the homepage #13885

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

nloureiro
Copy link
Contributor

small css touch on the erros on the homepage

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1ed1825
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66e951f5b4da4400087af3eb
😎 Deploy Preview https://deploy-preview-13885--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 36 (🔴 down 12 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey :) can you be clearer on what this does/why?

@nloureiro
Copy link
Contributor Author

Hey :) can you be clearer on what this does/why?

Yes sure.

While testing, I saw we handled the error in the big numbers section like this, using the same style as the big text.
Screen Shot 2024-09-17 10 42 07 AM

With this PR, I want to make the error a little bit more discreet: smaller font size and body medium color on the text.
Like this:
Screen Shot 2024-09-17 12 47 46 AM

@wackerow wackerow changed the title small css touch on the erros on the homepage small css touch on the errors on the homepage Sep 23, 2024
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wackerow wackerow merged commit 2dac3e5 into dev Sep 23, 2024
8 of 10 checks passed
@wackerow wackerow deleted the homepage-error-bignumbers branch September 23, 2024 16:29
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants