-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Md layouts tw migration & unification #13843
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pettinarip does this ones fall under a different template? my take is that all should follow the DS heroes, and these ones are still different. |
They do, they are different layouts. You can see that the ones that we changed have the left sidenav and the content on the right. However, we could create a different PR to update the heros for those pages if we all agree. But I wouldn't include that in this PR. |
Cool! thanks for the early feedback @nloureiro.
Ok, let me see how we can keep this.
Hmm ok. Got the idea but this section is used for the breadcrumbs and they are supposed to be links. But we don't have a page under |
lgtm what pablo did, regarding nuno's question about merging all headers according to the template: maybe just worried how the ETH page would look like with gradient, not a very strong stance here. Personally i think the design without gradient looks clearer and simpler and less corporate, but that is a different conversation. |
True, they are supposed to be breadcrumbs but:
this falls out of scope for this PR, but we need to think how to make the navigation and breadcrumbs match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!! 🔥 💪
Thanks for this, nice job @pettinarip!
Description
Effort to consolidate similar looking layouts.
ContentLayout
that uses theContentHero
ContentLayout
: Upgrade, Roadmap, Staking, Translatathon, and UseCasesTODO
ContentLayout