Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EthPriceCard, update associate color tokens #13828

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 8, 2024

Extends colors-1 branch in PR:

(Can be merged in any order)

Description

  • Updates EthPriceCard
  • This component utilized success/error colors, so was used as an opportunity to sync theme with Figma DS
  • Updates red/yellow/green color palettes; trims orange palette to only what is left being used
  • Updates naming of success/error/warning tokens per DS, and updates overall ordering of tokens to match DS

Related Issue

Design system gradient/color updates

@wackerow wackerow added the design system this label will be used in all issues related to design system label Sep 8, 2024
@wackerow wackerow changed the base branch from dev to colors-1 September 8, 2024 23:49
Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6f724bd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66df7a25190f33000834f781
😎 Deploy Preview https://deploy-preview-13828--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 34 (🔴 down 14 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 87 (🔴 down 5 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nloureiro
Copy link
Contributor

@wackerow added the same gradient on both themes because on dark there was no gradient.

I know that in production the dark theme does not have a visible gradient, but I think we can fix this.

Screen Shot 2024-09-09 10 49 07 PM
Screen Shot 2024-09-09 10 48 59 PM
Screen Shot 2024-09-09 10 56 35 PM

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! and nice colors cleanup 💪🏼

@pettinarip pettinarip merged commit 510d1a1 into colors-1 Sep 10, 2024
10 checks passed
@pettinarip pettinarip deleted the c1-pricecard branch September 10, 2024 08:32
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design system this label will be used in all issues related to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants