Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ExpandableInfo and runNodeGradient2 #13827

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 8, 2024

Description

ExpandableInfo component only used in one place, with significant portions of the component no longer being utilized, nor necessary. Contains the only usage of the runNodeGradient2 token.

  • refactor: Updates the single usage point of ExpandableInfo to use tailwind/shadcn instead
  • deprecate: ExpandableInfo component
  • theme: deprecate runNodeGradient2 token
image

Related Issue

Design system gradient/color migration

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6419e89
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66de0a0cb22f2f000867afa1
😎 Deploy Preview https://deploy-preview-13827--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 39 (🔴 down 9 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit b68b738 into dev Sep 9, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the deprecate-expandable-info branch September 9, 2024 13:03
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants