Skip to content

Update index.md of Merkle-Patricia Trie doc#13758

Merged
corwintines merged 3 commits into
ethereum:devfrom
TakeASwing-420:dev
Jan 13, 2025
Merged

Update index.md of Merkle-Patricia Trie doc#13758
corwintines merged 3 commits into
ethereum:devfrom
TakeASwing-420:dev

Conversation

@TakeASwing-420
Copy link
Copy Markdown
Contributor

@TakeASwing-420 TakeASwing-420 commented Aug 31, 2024

Description

Refactored the variable name node to node_hash to remove ambiguity. This change improves code clarity by explicitly indicating that the variable holds the hash of a node, not the node itself.

Changes

  • Replaced node with node_hash throughout the update and delete functions.

@TakeASwing-420
Update index.md
ee66031 
I replaced the node parameter with node_hash to remove ambiguity.
@github-actions github-actions Bot added the content 🖋️ This involves copy additions or edits label Aug 31, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 31, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 095523e
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66d817ccfabff20008b83e97
😎 Deploy Preview https://deploy-preview-13758--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 46 (🔴 down 4 from production)
Accessibility: 94 (🟢 up 2 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TakeASwing-420 TakeASwing-420 changed the title Update index.md Update index.md of Merkle-Patricia Trie doc Aug 31, 2024
@corwintines corwintines self-assigned this Sep 4, 2024
corwintines
corwintines approved these changes Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TakeASwing-420

I fixes the areas where this update was missed in the codeblock. The parameters were changed, but not their use in the functions.

@corwintines
Copy link
Copy Markdown
Member

corwintines commented Sep 4, 2024

@all-contributors can you add @TakeASwing-420 for content

@allcontributors allcontributors Bot mentioned this pull request Sep 4, 2024
Closed
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Sep 4, 2024

@corwintines

I've put up a pull request to add @TakeASwing-420! 🎉

corwintines
corwintines suggested changes Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TakeASwing-420 upon reviewing this file a bit more, I think this change is missing out throughout other code examples. Could you go through and fix this please :)

@corwintines corwintines added Status: Blocked 🛑 This is blocked awaiting changes Awaiting requested changes and removed Status: Blocked 🛑 This is blocked labels Sep 4, 2024
@TakeASwing-420
Update index.md
095523e 
Update remaininingcode blocks of Merkle Patricia Trie Documentation for better understanding.
@TakeASwing-420
Copy link
Copy Markdown
Contributor Author

TakeASwing-420 commented Sep 4, 2024

@corwintines Please Check the updates and tell if it's okay.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 5, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 5, 2024
@corwintines corwintines merged commit a09b7d0 into ethereum:dev Jan 13, 2025
@gitpoap-bot
Copy link
Copy Markdown

gitpoap-bot Bot commented Jan 13, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Jan 29, 2025
Merged
Merged
wackerow added a commit that referenced this pull request Jul 18, 2025
@wackerow
patch: node_hash reversion
596df26 
#14486 accidentally reverted; reinstates changes from #13758
@wackerow wackerow mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm

1 more reviewer

@corwintines corwintines corwintines approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@corwintines corwintines

Labels

awaiting changes Awaiting requested changes content 🖋️ This involves copy additions or edits Status: Stale This issue is stale because it has been open 30 days with no activity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TakeASwing-420 @corwintines