Skip to content

Adding Grandine to various pages #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

arredr2
Copy link
Contributor

@arredr2 arredr2 commented Aug 17, 2024

Description

I updated the following pages by adding Grandine to any mention of CL clients.
- Nodes and clients (https://ethereum.org/en/developers/docs/nodes-and-clients)
- Client diversity (https://ethereum.org/en/developers/docs/nodes-and-clients/client-diversity/#consensus-clients)
- Ethereum Support (https://ethereum.org/en/community/support/#consensus-clients)
- Adding staking products or services (https://ethereum.org/en/contributing/adding-staking-products/#node-or-client-tooling)
- Ethereum Governance (https://ethereum.org/en/governance/#who-is-involved)

Related Issue

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Aug 17, 2024
Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 32eb2c7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66cc8635a5b4450008b4f724
😎 Deploy Preview https://deploy-preview-13677--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 40 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arredr2! Correct me if I'm wrong, but Grandine appears to still be in beta, with release version <v1 still. Left some comments; don't see why we can't still list Grandine, but in the past we've marked those not yet fully in production as (beta) and graduate it over time when ready.

@@ -195,12 +195,19 @@ There are multiple consensus clients (previously known as 'Eth2' clients) to sup

| Client | Language | Operating systems | Networks |
| ------------------------------------------------------------- | ---------- | --------------------- | ----------------------------------------------------------------- |
| [Grandine](https://docs.grandine.io/) | Rust | Linux, Windows, macOS | Beacon Chain, Goerli, Sepolia, and more |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to last and mark with (beta) at the end given we are not yet at a v1 production release.

Comment on lines 205 to 210
### Grandine {#grandine}

Grandine is the latest consensus client implementation, written in Rust under the GPL-3.0 license. It is maintained by the Grandine Core Team and is fast, high-performance and lightweight. It fits a wide range of stakers from solo stakers running on low-resource devices such as Raspberry Pi to large institutional stakers running tens of thousands of validators.

Documentation can be found in the [Grandine Book](https://docs.grandine.io/)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to end (below Teku)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would avoid phrasing such as "the latest consensus client" as this can change.

Comment on lines 83 to 84
[Grandine](https://github.com/grandinetech/grandine)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would avoid this listing until Grandine is out of beta with at least a v1 release

Suggested change
[Grandine](https://github.com/grandinetech/grandine)

@arredr2
Copy link
Contributor Author

arredr2 commented Aug 26, 2024

@wackerow thanks for your comments! I have updated based on your suggestions.

@arredr2 arredr2 requested a review from wackerow August 31, 2024 00:57
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @arredr2!

@wackerow wackerow merged commit 97b4afc into ethereum:dev Sep 2, 2024
6 checks passed
@arredr2 arredr2 deleted the Grandine-updates branch September 3, 2024 17:11
This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants