-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Adding Grandine to various pages #13677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arredr2! Correct me if I'm wrong, but Grandine appears to still be in beta, with release version <v1 still. Left some comments; don't see why we can't still list Grandine, but in the past we've marked those not yet fully in production as (beta)
and graduate it over time when ready.
@@ -195,12 +195,19 @@ There are multiple consensus clients (previously known as 'Eth2' clients) to sup | |||
|
|||
| Client | Language | Operating systems | Networks | | |||
| ------------------------------------------------------------- | ---------- | --------------------- | ----------------------------------------------------------------- | | |||
| [Grandine](https://docs.grandine.io/) | Rust | Linux, Windows, macOS | Beacon Chain, Goerli, Sepolia, and more | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to last and mark with (beta)
at the end given we are not yet at a v1 production release.
### Grandine {#grandine} | ||
|
||
Grandine is the latest consensus client implementation, written in Rust under the GPL-3.0 license. It is maintained by the Grandine Core Team and is fast, high-performance and lightweight. It fits a wide range of stakers from solo stakers running on low-resource devices such as Raspberry Pi to large institutional stakers running tens of thousands of validators. | ||
|
||
Documentation can be found in the [Grandine Book](https://docs.grandine.io/) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to end (below Teku)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would avoid phrasing such as "the latest consensus client" as this can change.
[Grandine](https://github.com/grandinetech/grandine) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would avoid this listing until Grandine is out of beta with at least a v1 release
[Grandine](https://github.com/grandinetech/grandine) |
@wackerow thanks for your comments! I have updated based on your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @arredr2!
Description
I updated the following pages by adding Grandine to any mention of CL clients.
- Nodes and clients (https://ethereum.org/en/developers/docs/nodes-and-clients)
- Client diversity (https://ethereum.org/en/developers/docs/nodes-and-clients/client-diversity/#consensus-clients)
- Ethereum Support (https://ethereum.org/en/community/support/#consensus-clients)
- Adding staking products or services (https://ethereum.org/en/contributing/adding-staking-products/#node-or-client-tooling)
- Ethereum Governance (https://ethereum.org/en/governance/#who-is-involved)
Related Issue