Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard shortcut conflict #13642

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: keyboard shortcut conflict #13642

merged 1 commit into from
Aug 15, 2024

Conversation

wackerow
Copy link
Member

Description

  • Patches the keyboard shortcut for the Language Picker to exclude usage of the meta (cmd/win) or ctrl keys when using the \ shortcut
  • Avoids cmd/ctrl-\ from opening lang menu; reserved for color mode change

avoid cmd/ctrl-\ from opening lang menu; reserved for color mode change
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e830a20
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66bd5c5aff952c0008854202
😎 Deploy Preview https://deploy-preview-13642--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 41 (🔴 down 7 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 14 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wackerow

@pettinarip pettinarip merged commit acc8756 into dev Aug 15, 2024
10 checks passed
@pettinarip pettinarip deleted the fix-kbd-shortcut branch August 15, 2024 12:11
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants