Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate css imports into global.css #13641

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

wackerow
Copy link
Member

Description

  • Consolidates all css imports into the global.css file
  • Moves other global css imports as an @import statement within global.css

cc: @pettinarip Not sure if we would also like to revert the recent updates to the ESLint rule changes with this PR. Happy to, just drop a note if you'd prefer one way or the other.

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9fb112d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66bf9fa83f07550008a7852a
😎 Deploy Preview https://deploy-preview-13641--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🔴 down 6 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip
Copy link
Member

Description

  • Consolidates all css imports into the global.css file
  • Moves other global css imports as an @import statement within global.css

cc: @pettinarip Not sure if we would also like to revert the recent updates to the ESLint rule changes with this PR. Happy to, just drop a note if you'd prefer one way or the other.

That would be ideal @wackerow. This PR looks good though, approving but waiting for that final change if possible.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

reserve only for .scss or .css pattern
@github-actions github-actions bot added the config ⚙️ Changes to configuration files label Aug 16, 2024
@pettinarip pettinarip merged commit 6ec62c3 into dev Aug 19, 2024
10 checks passed
@pettinarip pettinarip deleted the css-import-consolidation branch August 19, 2024 09:45
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants