Shadcn migration - /get-eth page
#13597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
commented
Aug 19, 2024
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
wackerow
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Nice job @pettinarip, great start here... left a couple comments highlighting a few changes and potential improvements.
I see some layout shifts compared to production, which look good to me but will let @nloureiro and/or @konopkja chime in as well.
Co-authored-by: Paul Wackerow <[email protected]>
wackerow
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looks great!! Nice job @pettinarip... Some discussion about the font size within the old InfoBanner callouts... PR is currently aligned with the DS, so going to approve and pull this in. Can discuss those changes separately.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the
/get-ethpage to Tailwind.Preview link
https://deploy-preview-13597--ethereumorg.netlify.app/en/get-eth/