[ShadCN] refactor(pages/what-is-ethereum): migrate to ShadCN #13572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg canceled.
|
TylerAPfledderer
force-pushed
the
refactor/what-is-ethereum-shadcn
branch
from
d8d4e12
to
f7d2e87
Compare
TylerAPfledderer
changed the title
|
I would say that the Learn Page PR is a blocker here; it is establishing the import of the new buttons and links, which means movement of various files. Once that is done and merged, then update this PR and those imports for the "What is Ethereum" page. |
|
@pettinarip should be good now |
pettinarip
requested changes
Aug 15, 2024
There was a problem hiding this comment.
@TylerAPfledderer looks good overall. Left a few comments to try to standarize some colors and spacing values. Didn't add a comment in all of the occurrences but you will get the point. Lets see if we can use the tw scale as much as we can.
…a to make it consistent
pettinarip
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Nice job @TylerAPfledderer.
Will validate a few things with Nuno and then merge it.
This was referenced Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the "What is Ethereum" page to remove direct Chakra imports and use ShadCN components and Tailwind.