Implement Updated Button Component from Design System also Fixes Text Overflow Issues#13523
Implement Updated Button Component from Design System also Fixes Text Overflow Issues#13523jenish-thapa wants to merge 1 commit into
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @wackerow, please check the preview. Also please let me know if any modifications required |
|
This issue is stale because it has been open 30 days with no activity. |
|
@jenish-thapa Oh, this looks very good. Thank you!!!! I was testing, and they should not collapse. I'm double-thinking and testing on your dev preview and prefer higher buttons over one on top of the other. So, from the design side, I think we should make them:
What do you think? |
|
This issue is stale because it has been open 30 days with no activity. |
|
@jenish-thapa are you still up to finishing this based on my last comments? |
|
@all-contributors please add @jenish-thapa for ideas |
|
I've put up a pull request to add @jenish-thapa! 🎉 |


Pull Request: Implement Updated Button Component from Design System
Description
This PR addresses the issue where the text on the 'Previous' and 'Next' buttons was coming out of the box in certain languages, like Russian, and was touching the underline. This was especially noticeable on the page
ethereum.org/en/developers/docs/evm/opcodes/.Changes Made
Screenshots
How to Test
ethereum.org/en/developers/docs/evm/opcodes/.Additional Context
Issue Link
Fixes #13405
Feel free to assign the task to me. Looking forward to your feedback!