Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MEV to glossary #13479

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Add MEV to glossary #13479

merged 6 commits into from
Jul 29, 2024

Conversation

JoshDavisLight
Copy link
Contributor

@JoshDavisLight JoshDavisLight commented Jul 24, 2024

Description

Added MEV to glossary and updated definition in json file.

Related Issue

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 046b166
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66a7cc117827810008b6c954
😎 Deploy Preview https://deploy-preview-13479--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 91 (🔴 down 8 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jul 24, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshDavisLight, left a suggestion!

src/intl/en/glossary.json Outdated Show resolved Hide resolved
@JoshDavisLight
Copy link
Contributor Author

Thanks @wackerow. I took your suggestion, as well as added a link to the MEV page in the developer docs.

@Romansharar
Copy link

Romansharar commented Jul 29, 2024 via email

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JoshDavisLight

@corwintines corwintines merged commit af685db into ethereum:dev Jul 29, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Jul 29, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @JoshDavisLight for content

Copy link
Contributor

@wackerow

I've put up a pull request to add @JoshDavisLight! 🎉

This was referenced Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum Extractable Value (MEV)
4 participants