Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: padding between navbar and dapps page hero #13436

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

MahendraBishnoi29
Copy link
Contributor

@MahendraBishnoi29 MahendraBishnoi29 commented Jul 20, 2024

Description

Reduced Padding Between Navbar and Ethereum-Powered Tools and Services Banner In Dapps Page

before reducing padding top
image

after reducing padding top
image

Related Issue

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9858ad0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/669b383af7ab34000817847d
😎 Deploy Preview https://deploy-preview-13436--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 7 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines
Copy link
Member

@nloureiro do you mind giving this a review

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nloureiro If you wouldn't mind taking a look here.

By adjusting at the PageHero level we're adjusting the hero on /dapps, but also affecting:

  • /gas
  • /run-a-node
  • /stablecoins
  • /staking
  • /roadmap/vision
  • /wallets

We should consider the impact here since quickly eye-balling a few of these, they look a little cramped with the top padding chopped in half.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 25, 2024
@nloureiro
Copy link
Contributor

@nloureiro If you wouldn't mind taking a look here.

By adjusting at the PageHero level we're adjusting the hero on /dapps, but also affecting:

  • /gas
  • /run-a-node
  • /stablecoins
  • /staking
  • /roadmap/vision
  • /wallets

We should consider the impact here since quickly eye-balling a few of these, they look a little cramped with the top padding chopped in half.

Sorry for the late response here. I'm ok with this.
we need to migrate this to the DS hero at some point, so let's go like this now

@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 27, 2024
@wackerow wackerow merged commit d930c0a into ethereum:dev Aug 27, 2024
8 of 10 checks passed
@MahendraBishnoi29 MahendraBishnoi29 deleted the mahendra/spacing-fix branch August 28, 2024 08:29
This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Excessive Space Between Navbar and Ethereum-Powered Tools and Services Banner
4 participants