-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: padding between navbar and dapps page hero #13436
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@nloureiro do you mind giving this a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nloureiro If you wouldn't mind taking a look here.
By adjusting at the PageHero
level we're adjusting the hero on /dapps
, but also affecting:
/gas
/run-a-node
/stablecoins
/staking
/roadmap/vision
/wallets
We should consider the impact here since quickly eye-balling a few of these, they look a little cramped with the top padding chopped in half.
This issue is stale because it has been open 30 days with no activity. |
Sorry for the late response here. I'm ok with this. |
Description
Reduced Padding Between Navbar and Ethereum-Powered Tools and Services Banner In Dapps Page
before reducing padding top
after reducing padding top
Related Issue