Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup "Go to top" button for translation #13373

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Setup "Go to top" button for translation #13373

merged 1 commit into from
Jul 15, 2024

Conversation

corwintines
Copy link
Member

Description

  • Set up "Go to top" button in Footer for translation

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jul 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8063914
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/668ec06be7162f0008e85967
😎 Deploy Preview https://deploy-preview-13373--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 51 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 5 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

minimalsm
minimalsm approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty @corwintines

@minimalsm minimalsm merged commit 30601ac into dev Jul 15, 2024
9 of 10 checks passed
@minimalsm minimalsm deleted the setupTranslationBackToTop branch July 15, 2024 11:17
This was referenced Jul 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwintines @minimalsm