Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use @font-face import for mono font #13364

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Moves the file for the IBM Plex Mono font to the public folder, and import via @font-face.

This matches the strategy for the Inter font

Fixes issue where mono font was not loading into Storybook.

Related Issue

Issue in Storybook exposed in #13347

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jul 9, 2024
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 284af3e
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/668ded2346fbf500085376c4
😎 Deploy Preview https://deploy-preview-13364--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 5 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks @TylerAPfledderer

@pettinarip pettinarip merged commit e1e43fe into ethereum:dev Jul 10, 2024
9 of 10 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/mono-font-static-import branch July 10, 2024 15:21
This was referenced Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants