Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth page video graphic path #13356

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

It fixes ethereum-hero-light.mp4 inappropriate path at What is ETH? page. Resolves [#13349]

Related Issue

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f412bd8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/668c386dd86c8000088efdad
😎 Deploy Preview https://deploy-preview-13356--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 88 (🔴 down 4 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @saurabhburade

@corwintines
Copy link
Member

@allcontributors can you add @saurabhburade for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @saurabhburade! 🎉

@corwintines corwintines merged commit 79f6296 into ethereum:dev Jul 8, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Jul 8, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

Looks great, thanks @saurabhburade! Small house-keeping tip, in the future if you place Fixes #12345 (the issue number) in the PR message body, it will automatically be linked to the issue, and that issue will be closed automatically if/when the PR is merged. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants