Create story for Trilemma component [#13250]#13300
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
left a comment
There was a problem hiding this comment.
Thanks @Tutizaraz!
I'm seeing a few differences from the story to production I'll just note:
- Missing background on "Explore the scalability trilemma" box (@nloureiro Looks like this is still using
--eth-colors-ednBackgroundin production... I assume we won't update that here, but just noting) - Font color for the three triangle vertices ("DECENTRALIZATION", "SECURITY", "SCALABILITY")... should be
body.baseI believe. - Triangle and circles: should be white in light mode.
- Need padding on edges (mobile)
- Height should probably be unbounded
| <ChakraProvider> | ||
| <Box | ||
| w="100vw" | ||
| h="100vh" |
|
@Tutizaraz Small housekeeping note: Just references an issue by In the body of your PR, ideally place this under "## Related issue", and provide a description under "## Description". Pro-tip, place it as a markdown list item: ...which makes it render like this on GitHub: Helps us all stay more organized =) Thanks! Fyi, you can confirm it's working by looking at the "Development" section in this PR, which currently is showing this:
...but will show the issue when properly linked |
|
This issue is stale because it has been open 30 days with no activity. |
Since this is a Storybook PR, the focus should be on the component itself (Trilemma) rather than adjusting the story to match production. I'd argue for (most) points here the discrepancies between the component in Storybook and production are issues with the component’s implementation/styles, not the story setup? we should avoid hardcoding styles in the stories to match production as this could introduce side effects. any thoughts @pettinarip @corwintines @TylerAPfledderer? |
@minimalsm The story is intended to match production to demonstrate the components intended use when in isolation. If the story is not matching production, then either decorator created to show it's context is not built correctly, or the story is exposing other issues with the component that are not clear in production. There are some components that were built for a space that are not as wide as the preview container of storybook. We need a decorator in those instances to restrain the width of the component, so that the component is represented correctly without forcing styles to it that should be handled by a parent. In this case, the decorator provided is a little excessive (the It can be argued that the background gradient should not be placed in the component because in production, you have a container surrounding the component with it's own padding, and that the gradient color fills the entire space. So should that wrapping container that I do understand the issue of there being side-effects because there could end up being a mismatch if the page layout is updated at a later time. I would argue here for reusable UI to be used in production and as decorators for some of these components. Knowing that the new DS is looking to simplifying the design and provide more consistency with layout helps this idea tremendously. @pettinarip this last point has been on my mind since I've done decorators with other stories to help with context, and I believe reusability exists here. |
|
This issue is stale because it has been open 30 days with no activity. |
Move placement to organisms/layouts/trilemma as it is comprised of multiple molecules
wackerow
left a comment
There was a problem hiding this comment.
Hey folks, circling back... Cleaned this up a bit, though not sure it fully addresses concerns above.
- Converted to tailwind classes
- Matched container style to prod
- Moved placement to Organisms/Layouts since it's not really a molecule or atom
- Updated to latest
dev
Going to approve, but cc: @pettinarip if you could eyeball
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Ethereum.org Contributor: Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱 Learn more about GitPOAPs here. |
|
@all-contributors please add @dbarabashh for code |
|
I've put up a pull request to add @dbarabashh! 🎉 |








Description
Added a story for Trilemma component
Related issue