Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup list improvements #13216

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Meetup list improvements #13216

merged 4 commits into from
Jun 24, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 20, 2024

Description

  • Fixes namespace bug causing "no results" strings to be broken
  • Cleans up emoji fields inside community-meetups.json to remove uses of two-character region codes or emojis, and utilize full region names instead (which parse to the same flags that were already shown).
  • Expanded the filtering/searching to take advantage of these region names, allowing a user to search by a country name

Preview URL:

https://deploy-preview-13216--ethereumorg.netlify.app/en/community/events/#meetups

Screenshots

image image

Related Issue

https://ethereum.org/en/community/events/

image

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 12668d8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6675a700cadc34000801cfc8
😎 Deploy Preview https://deploy-preview-13216--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 42 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines merged commit 4d9f0b6 into dev Jun 24, 2024
10 checks passed
@corwintines corwintines deleted the meetup-cleanup branch June 24, 2024 18:57
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants