Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gem Wallet to Wallets #13213

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Add Gem Wallet to Wallets #13213

merged 5 commits into from
Jun 24, 2024

Conversation

wrexgem
Copy link
Contributor

@wrexgem wrexgem commented Jun 20, 2024 •
edited by wackerow
Loading

Description

New PR to get Gem Wallet added to the Catalogue of Wallets on ethereum.org. See approved issue below. Thank you!

Related Issue

@netlify Netlify
Copy link

netlify bot commented Jun 20, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 782c6f3
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6679fa9e6e7a0c0009456470
😎 Deploy Preview https://deploy-preview-13213--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 45 (🔴 down 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wrexgem wrexgem mentioned this pull request Jun 20, 2024
Closed
2 tasks
wackerow
wackerow requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wrexgem! Couple notes

src/data/wallets/wallet-data.ts Outdated Show resolved Hide resolved
src/data/wallets/wallet-data.ts Outdated Show resolved Hide resolved
wrexgem and others added 2 commits June 25, 2024 00:45
@wrexgem
Copy link
Contributor Author

wrexgem commented Jun 24, 2024 •
edited
Loading

Thank you @wackerow - Added NFT tag and removed new to crypto tag. Should be good now!

wackerow
wackerow approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @wrexgem

@wackerow wackerow merged commit f1005ab into ethereum:dev Jun 24, 2024
2 checks passed
@wackerow
Copy link
Member

@all-contributors please add @wrexgem for tool

@allcontributors allcontributors bot mentioned this pull request Jun 24, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @wrexgem! 🎉

This was referenced Jul 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konopkja konopkja konopkja left review comments

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest a wallet (Gem Wallet)
3 participants
@wrexgem @wackerow @konopkja