Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update /staking testnet references to Holesky [Fixes #13168] #13187

Merged
merged 34 commits into from
Jun 24, 2024

Conversation

SnehalSrivastava27
Copy link
Contributor

Made all the translation changes required in the src/intl/**/page-staking.json

@github-actions github-actions bot added the translation 🌍 This is related to our Translation Program label Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3cdeb6d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667354fe40870b000824e75c
😎 Deploy Preview https://deploy-preview-13187--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🟢 up 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the title update staking launchpad to use Holesky testnet [Fixes #13168] Fixed Translation and Documentation update staking launchpad to use Holesky testnet [Fixes #13168] Jun 18, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukassim Hey, I went through Crowdin and updated age-staking-launchpad-widget-testnet-label and age-staking-launchpad-widget-testnet-start for all completed langs, but I didn't do these other two:

  • comp-withdrawal-credentials-verify-goerli
  • page-staking-launchpad-widget-p1

Any chance you could help get these updated as well? And is it going to cause issues if we change this id here?

@SnehalSrivastava27 If we make a change to the string id's, we should make sure they stay lowercase, ie -Holesky should be -holesky throughout

@SnehalSrivastava27
Copy link
Contributor Author

@wackerow got it will make the changes and update in a while.

@lukassim
Copy link
Contributor

@lukassim Hey, I went through Crowdin and updated age-staking-launchpad-widget-testnet-label and age-staking-launchpad-widget-testnet-start for all completed langs, but I didn't do these other two:

  • comp-withdrawal-credentials-verify-goerli
  • page-staking-launchpad-widget-p1

Any chance you could help get these updated as well? And is it going to cause issues if we change this id here?

@SnehalSrivastava27 If we make a change to the string id's, we should make sure they stay lowercase, ie -Holesky should be -holesky throughout

Hey,
No, changing the id shouldn't cause any issues
Just let me know when the content is final and we can get any remaining content translated

@wackerow wackerow changed the title update staking launchpad to use Holesky testnet [Fixes #13168] update /staking testnet references to Holesky [Fixes #13168] Jun 19, 2024
@wackerow
Copy link
Member

Great thanks @lukassim... @SnehalSrivastava27 Thanks for the additional changes! I pushed a couple commits to help get this over the line after spotting a few other usages on the /staking pages, and some overlap with the /staking/withdrawals page.

I think that just about does it for all the /staking pages.

@wackerow
Copy link
Member

Working well, pulling in. Thanks @SnehalSrivastava27!

@wackerow wackerow merged commit febbae7 into ethereum:dev Jun 24, 2024
9 of 11 checks passed
Copy link

gitpoap-bot bot commented Jun 24, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @SnehalSrivastava27 for maintenance

Copy link
Contributor

@wackerow

I've put up a pull request to add @SnehalSrivastava27! 🎉

@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 1, 2024
This was referenced Jul 10, 2024
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants