-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update /staking testnet references to Holesky [Fixes #13168] #13187
Conversation
Corrected the Arabic translation
Update page-staking.json
Update page-staking.json
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukassim Hey, I went through Crowdin and updated age-staking-launchpad-widget-testnet-label
and age-staking-launchpad-widget-testnet-start
for all completed langs, but I didn't do these other two:
comp-withdrawal-credentials-verify-goerli
page-staking-launchpad-widget-p1
Any chance you could help get these updated as well? And is it going to cause issues if we change this id here?
@SnehalSrivastava27 If we make a change to the string id's, we should make sure they stay lowercase, ie -Holesky
should be -holesky
throughout
@wackerow got it will make the changes and update in a while. |
Hey, |
fixes label an link used to check withdrawal credential status
Great thanks @lukassim... @SnehalSrivastava27 Thanks for the additional changes! I pushed a couple commits to help get this over the line after spotting a few other usages on the I think that just about does it for all the |
Working well, pulling in. Thanks @SnehalSrivastava27! |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
@all-contributors please add @SnehalSrivastava27 for maintenance |
I've put up a pull request to add @SnehalSrivastava27! 🎉 |
Made all the translation changes required in the src/intl/**/page-staking.json