Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the /public dir #13166

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Clean the /public dir #13166

merged 2 commits into from
Jun 16, 2024

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Jun 13, 2024 •
edited by wackerow
Loading

Description

  • Moves all images in the /public folder from /public to /public/images
  • Updates paths for image use

Related Issue

@netlify Netlify
Copy link

netlify bot commented Jun 13, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 42ab0e8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/666b815ad425920008fc245a
😎 Deploy Preview https://deploy-preview-13166--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 43 (🟢 up 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jun 13, 2024
@wackerow wackerow added refactor ♻️ Changes which don't affect functionality and removed content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 14, 2024
wackerow
wackerow approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lukassim, we'll probably want to upload everything to Crowdin once this is in, since we don't want the next round to revert all these image path adjustments.

Thanks @corwintines, looks good!

pettinarip
pettinarip approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice job @corwintines

@wackerow wackerow merged commit 4c813d0 into dev Jun 16, 2024
10 of 11 checks passed
@wackerow wackerow deleted the cleanPublicFolder branch June 16, 2024 17:38
This was referenced Jun 19, 2024
Merged
Merged
@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 1, 2024
@wackerow wackerow mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip pettinarip approved these changes

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
refactor ♻️ Changes which don't affect functionality tooling 🔧 Changes related to tooling of the project Update Crowdin PR introduces changes that need to be updated in Crowdin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean the /public dir
3 participants
@corwintines @pettinarip @wackerow