Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix icons alignment in wallets page #13157

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

MahendraBishnoi29
Copy link
Contributor

@MahendraBishnoi29 MahendraBishnoi29 commented Jun 13, 2024

Description

fixed icons alignment in this page

Related Issue

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b94f260
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66710caf644c690008fdc986
😎 Deploy Preview https://deploy-preview-13157--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🟢 up 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MahendraBishnoi29!

Assigning @wackerow to check this out.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MahendraBishnoi29! Going to bring this in as it's a minimal adjustment which addresses the issue.

cc: @nloureiro or @konopkja Feel free to comment/create an issue if you disagree with a slightly larger icon here (or if you think maybe it could be even bigger)... can always adjust further.

@wackerow wackerow merged commit c04bdb6 into ethereum:dev Jun 22, 2024
9 of 10 checks passed
Copy link

gitpoap-bot bot commented Jun 22, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@MahendraBishnoi29 MahendraBishnoi29 deleted the mahendra/icons-alignment-fix branch June 26, 2024 13:16
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons alignment issue on /wallets/#sim page
3 participants