Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: optimize hero images #13106

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

pettinarip
Copy link
Member

Description

Implements the sizes prop where it is missing to get a more optimized image especially in smaller resolutions.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7f18947
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/665f1a306737be0007c62e52
😎 Deploy Preview https://deploy-preview-13106--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🟢 up 9 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Page Performance Accessibility Best practices SEO PWA
/en/ 🟠 50 🟢 94 🟢 93 🟢 93 🔴 38
/en/wallets/find-wallet/ 🟠 51 🟠 88 🟢 96 🟢 93 🔴 38
/en/staking/ 🟠 51 🟢 91 🟢 93 🟢 93 🔴 38
/en/whitepaper/ 🟠 65 🟢 95 🟢 96 🟢 93 🔴 38
/en/nft/ 🔴 45 🟢 95 🟢 96 🟢 93 🔴 38
/en/developers/docs/intro-to-ethereum/ 🟠 61 🟢 94 🟢 96 🟢 93 🔴 38
/en/developers/tutorials/creating-a-wagmi-ui-for-your-contract/ 🟠 60 🟠 88 🟢 96 🟢 93 🔴 38

Lighthouse scores are calculated based on the latest audit results

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 4d8fc25 into dev Jun 7, 2024
9 of 11 checks passed
@nhsz nhsz deleted the performance/optimize-hero-images branch June 7, 2024 15:33
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants