Fixed ether command on Ethereum Client APIs #13105
Conversation
Fixed ether command on Ethereum Client APIs
Changed ethers.providers.Web3Provider(window.ethereum) to
ethers.BrowserProvider(window.ethereum) & also
Wallet.fromMnemonic(mnemonics) to
Wallet.fromPhrase(mnemonics)
pglekshmi
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks @pglekshmi! Going to commit the adjustment to the comment then pull this in.
| @@ -80,7 +80,7 @@ Here's an examples from Ethers | |||
| // Create a wallet instance from a mnemonic... | |||
| mnemonic = | |||
| "announce room limb pattern dry unit scale effort smooth jazz weasel alcohol" | |||
| walletMnemonic = Wallet.fromMnemonic(mnemonic) | |||
| walletMnemonic = Wallet.fromPhrase(mnemonic) | |||
There was a problem hiding this comment.
Looks good! (supporting docs here for reference)
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @pglekshmi for maintenance |
|
I've put up a pull request to add @pglekshmi! 🎉 |
|
Thank you for accepting pull request & looking forward to do more contributions |
Fixed ether command on Ethereum Client APIs
Description
Changed
ethers.providers.Web3Provider(window.ethereum) --> ethers.BrowserProvider(window.ethereum) &
Wallet.fromMnemonic(mnemonics) --> Wallet.fromPhrase(mnemonics)